linux-kernel - Re: [PATCH v2 1/1] iommu/vtd: Cleanup dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Nov 2018 15:32:27 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     "Liu, Yi L" <yi.l.liu@...el.com>, Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>
Cc:     baolu.lu@...ux.intel.com, "Raj, Ashok" <ashok.raj@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
Subject: Re: [PATCH v2 1/1] iommu/vtd: Cleanup dma_remapping.h header

Hi,

On 11/12/18 3:20 PM, Liu, Yi L wrote:
>> bounces@...ts.linux-foundation.org] On Behalf Of Lu Baolu
>> Sent: Monday, November 12, 2018 2:40 PM
>> Subject: [PATCH v2 1/1] iommu/vtd: Cleanup dma_remapping.h header
>>
>> Commit e61d98d8dad00 ("x64, x2apic/intr-remap: Intel vt-d, IOMMU
>> code reorganization") moved dma_remapping.h from drivers/pci/ to
>> current place. It is entirely VT-d specific, but uses a generic
>> name. This merges dma_remapping.h with include/linux/intel-iommu.h
>> and removes dma_remapping.h as the result.
>>
>> Cc: Ashok Raj <ashok.raj@...el.com>
>> Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
>> Cc: Sohil Mehta <sohil.mehta@...el.com>
>> Suggested-by: Christoph Hellwig <hch@...radead.org>
>> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
>> Reviewed-by: Christoph Hellwig <hch@....de>
>> ---
> 
> Reviewed-by: Liu, Yi L <yi.l.liu@...el.com>
> 
> Just out of curious, did you considered to modify the original file
> name to be an intel specific file name? What makes you believe
> merging the file content to intel-iommu.h is better?

I don't think we need multiple headers for VT-d specific things.

Best regards,
Lu Baolu