linux-kernel - Re: [PATCH -next] USB: serial: mos7840: remove set but not used variables 'st, data1, iflag'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181112093549.GD13311@localhost>
Date:   Mon, 12 Nov 2018 10:35:49 +0100
From:   Johan Hovold <johan@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH -next] USB: serial: mos7840: remove set but not used
 variables 'st, data1, iflag'

On Fri, Oct 26, 2018 at 08:25:49PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/usb/serial/mos7840.c: In function 'mos7840_interrupt_callback':
> drivers/usb/serial/mos7840.c:604:14: warning:
>  variable 'st' set but not used [-Wunused-but-set-variable]
> 
> drivers/usb/serial/mos7840.c: In function 'mos7840_write':
> drivers/usb/serial/mos7840.c:1303:17: warning:
>  variable 'data1' set but not used [-Wunused-but-set-variable]
> 
> drivers/usb/serial/mos7840.c:1700:11: warning:
>  variable 'iflag' set but not used [-Wunused-but-set-variable]
> 
> They are never used since introduction in
> commit 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied, thanks.

Johan