linux-kernel - Re: [PATCH] HID: hidraw: enforce minors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Nov 2018 12:45:53 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:     "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: hidraw: enforce minors_lock locking via lockdep

On Fri, 9 Nov 2018, Benjamin Tissoires wrote:

> On Thu, Nov 8, 2018 at 10:38 PM Jiri Kosina <jikos@...nel.org> wrote:
> >
> > From: Jiri Kosina <jkosina@...e.cz>
> >
> > lockdep is much more powerful enforcing the locking rules than code comments,
> > so let's switch to it.
> >
> > Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> > ---
> 
> Looks good to me.
> 
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

I actually missed the comment removal for hidraw_get_report(). I've 
ammeded the patch and comitted, keeping your tag, please shout if you 
disagree :)

Thanks.

-- 
Jiri Kosina
SUSE Labs