linux-kernel - Re: [PATCH] infiniband/hw/hns/hns_roce_hw_v2.c: Use dma_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Nov 2018 17:34:42 +0530
From:   Sabyasachi Gupta <sabyasachi.linux@...il.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     oulijun@...wei.com, xavier.huwei@...wei.com, dledford@...hat.com,
        jgg@...pe.ca, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Subject: Re: [PATCH] infiniband/hw/hns/hns_roce_hw_v2.c: Use dma_zalloc_coherent

On Sat, Nov 10, 2018 at 11:57 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> On Fri, Nov 9, 2018 at 8:08 PM Sabyasachi Gupta
> <sabyasachi.linux@...il.com> wrote:
> >
> > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> There are few other places in this file where same is applicable.
> Can we get those changes in same patch ?
> >
as all the changes are now in linux-next I am going to drop this patch

> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> > ---
> >  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > index a4c62ae..c9966ec 100644
> > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > @@ -4972,13 +4972,12 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
> >                                 eqe_alloc = i * (buf_chk_sz / eq->eqe_size);
> >                                 size = (eq->entries - eqe_alloc) * eq->eqe_size;
> >                         }
> > -                       eq->buf[i] = dma_alloc_coherent(dev, size,
> > +                       eq->buf[i] = dma_zalloc_coherent(dev, size,
> >                                                         &(eq->buf_dma[i]),
> >                                                         GFP_KERNEL);
> >                         if (!eq->buf[i])
> >                                 goto err_dma_alloc_buf;
> >
> > -                       memset(eq->buf[i], 0, size);
> >                         *(eq->bt_l0 + i) = eq->buf_dma[i];
> >
> >                         eq_buf_cnt++;
> > --
> > 2.7.4
> >