linux-kernel - Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5DbuuVr7JVpK+DCsE4G=tksTg6CRrCGwyaNO55WDuyRzw@mail.gmail.com>
Date:   Mon, 12 Nov 2018 13:09:26 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Dong Aisheng <aisheng.dong@....com>
Cc:     Martin Kaiser <martin@...ser.cx>, Shawn Guo <shawnguo@...nel.org>,
        Stefan Agner <stefan@...er.ch>,
        Sascha Hauer <kernel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Leonard Crestez <leonard.crestez@....com>
Subject: Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

Hi Dong,

On Mon, Nov 12, 2018 at 1:04 PM A.s. Dong <aisheng.dong@....com> wrote:

> Thanks for reporting this issue.
> The original code intended to save 3 common lines for both SCU and MMIO pads,
> but it did change the code logic a bit which resulted in a regression specificly
> for NO_PAD_CTL cases used on a few legacy boards. (NO_PAD_CTL is deprecated
> for new boards dts).

Just a clarification: NO_PAD_CTL is not deprecated.

It is not recommended for new dts as we should not rely on the
bootloader pinctrl settings.

> As you both had a patch, i'm not sure who i'm going to expect for a updated one,
> so I would send it my own with both of your tags.

Yes, please send a patch putting a Reported-by tag from Martin and a
Suggested-by tag from Leonard.

Thanks