linux-kernel - Re: [PATCH] sched/rt: Introduce prio_{higher,lower}() helper for comparing RT task prority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPSr9jFqvSRoF1a-7rvMD+_1-Du2LvvwxoOMmyO_qStdS-dpCw@mail.gmail.com>
Date:   Mon, 12 Nov 2018 23:15:56 +0800
From:   Muchun Song <smuchun@...il.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        rostedt@...dmis.org
Subject: Re: [PATCH] sched/rt: Introduce prio_{higher,lower}() helper for
 comparing RT task prority

Hi Peter,

Ingo Molnar <mingo@...nel.org> 于2018年11月12日周一 下午2:57写道：
>
>
> * Peter Zijlstra <peterz@...radead.org> wrote:
>
> > I think you only need the less thing, because:
> >
> > static inline bool prio_lower(int a, int b)
> > {
> >       return a > b;
> > }
>
> I'd say that should be named rt_prio_lower(), even if it's local to
> sched/rt.c, right?
>

I agree with Ingo's point of view. Looks great. What is your opinion?
If you also agree. I will update the patch and send it.

Thanks.