linux-kernel - Re: [PATCH tip/core/rcu 10/41] drivers/ipmi: Replace synchronize_sched() with synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Nov 2018 08:04:25 -0800
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Corey Minyard <minyard@....org>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
        fweisbec@...il.com, oleg@...hat.com, joel@...lfernandes.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH tip/core/rcu 10/41] drivers/ipmi: Replace
 synchronize_sched() with synchronize_rcu()

On Mon, Nov 12, 2018 at 09:38:55AM -0600, Corey Minyard wrote:
> On 11/11/18 1:43 PM, Paul E. McKenney wrote:
> >Now that synchronize_rcu() waits for preempt-disable regions of code
> >as well as RCU read-side critical sections, synchronize_sched() can be
> >replaced by synchronize_rcu().  This commit therefore makes this change.
> 
> Assuming the above is true, this looks fine to me.
> 
> Acked-by: Corey MInyard <cminyard@...sta.com>

Thank you!

> Or I can take it in my tree, either way.

I will carry it unless/until I send it upstream (this coming merge
window) or I see it already upstream.

So your choice.  ;-)

							Thanx, Paul

> -corey
> 
> 
> >Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
> >Cc: Corey Minyard <minyard@....org>
> >Cc: Arnd Bergmann <arnd@...db.de>
> >Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >Cc: <openipmi-developer@...ts.sourceforge.net>
> >---
> >  drivers/char/ipmi/ipmi_si_intf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> >index 677618e6f1f7..dc8603d34320 100644
> >--- a/drivers/char/ipmi/ipmi_si_intf.c
> >+++ b/drivers/char/ipmi/ipmi_si_intf.c
> >@@ -2187,7 +2187,7 @@ static void shutdown_smi(void *send_info)
> >  	 * handlers might have been running before we freed the
> >  	 * interrupt.
> >  	 */
> >-	synchronize_sched();
> >+	synchronize_rcu();
> >  	/*
> >  	 * Timeouts are stopped, now make sure the interrupts are off
> 
>