linux-kernel - Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01bd2f70-cc78-9bfd-aa30-b73c44eaa9bb@kernel.dk>
Date:   Mon, 12 Nov 2018 10:10:16 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Jianchao Wang <jianchao.w.wang@...cle.com>
Cc:     ming.lei@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to
 accept NULL cookie pointer

On 11/12/18 2:23 AM, Jianchao Wang wrote:
> Make __blk_mq_issue_directly be able to accept a NULL cookie pointer
> and remove the dummy unused_cookie in blk_mq_request_issue_directly.

What's the reasoning behind this? Seems faster to store the cookie
always, instead of introducing a branch to the hot path.

-- 
Jens Axboe