linux-kernel - Re: [PATCH 04/11] ASoC: amd: add ACP3x PCM platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181113194122.GL2089@sirena.org.uk>
Date:   Tue, 13 Nov 2018 11:41:22 -0800
From:   Mark Brown <broonie@...nel.org>
To:     Vijendar Mukunda <Vijendar.Mukunda@....com>
Cc:     Alexander.Deucher@....com, Vishnuvardhanrao.Ravulapati@....com,
        Maruthi Bayyavarapu <maruthi.bayyavarapu@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Sanju R Mehta <sanju.mehta@....com>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>
Subject: Re: [PATCH 04/11] ASoC: amd: add ACP3x PCM platform driver

On Mon, Nov 12, 2018 at 11:04:55AM +0530, Vijendar Mukunda wrote:

> +static struct snd_pcm_ops acp3x_dma_ops = {
> +	.open = NULL,
> +	.close = NULL,
> +	.ioctl = NULL,
> +	.hw_params = NULL,
> +	.hw_free = NULL,
> +	.pointer = NULL,
> +	.mmap = NULL,
> +};
> +
> +struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
> +	.hw_params = NULL,
> +	.trigger   = NULL,
> +	.set_fmt = NULL,
> +};

Having these empty ops sets is really surprising - I see they do get
added later on, but there's no sign that this will happen here and
assigning NULL explicitly is generally bad.  It'd be better to just
leave these empty here so they don't look like a bug when doing review.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)