linux-kernel - Re: [PATCH] openrisc: make function cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181113204953.GF2718@lianli.shorne-pla.net>
Date:   Wed, 14 Nov 2018 05:49:53 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Changbin Du <changbin.du@...il.com>
Cc:     jonas@...thpole.se, stefan.kristiansson@...nalahti.fi,
        openrisc@...ts.librecores.org, linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH] openrisc: make function cache_loop() inline

On Mon, Nov 12, 2018 at 11:55:44PM +0800, Changbin Du wrote:
> The third operand of mtspr instruction must be a constraint. To guarantee
> this condition, function cache_loop() which uses macro mtspr() must be
> inlined. So let's force it as 'inline'. This is to fix compiling error with
> new option CONFIG_NO_AUTO_INLINE.

Thanks for looking at this.

Do you mean, must be a 'constant'?

I think this fix is fine for now.  Can you add it to your 'kernel hacking: GCC
optimization for better debug experience' series?

> In file included from arch/openrisc/mm/cache.c:17:0:
> arch/openrisc/mm/cache.c: In function 'cache_loop':
> arch/openrisc/include/asm/spr.h:20:27: warning: asm operand 0 probably doesn't match constraints
>                               ^
> arch/openrisc/mm/cache.c:29:3: note: in expansion of macro 'mtspr'
>       mtspr(reg, line);
>       ^~~~~
> arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm'
> 
> Signed-off-by: Changbin Du <changbin.du@...il.com>
> Reported-by: kbuild test robot <lkp@...el.com>
> Cc: Stafford Horne <shorne@...il.com>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Stafford Horne <shorne@...il.com>

> ---
>  arch/openrisc/mm/cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/openrisc/mm/cache.c b/arch/openrisc/mm/cache.c
> index b747bf1fc1b6..4a4b2b6e006b 100644
> --- a/arch/openrisc/mm/cache.c
> +++ b/arch/openrisc/mm/cache.c
> @@ -20,7 +20,7 @@
>  #include <asm/cacheflush.h>
>  #include <asm/tlbflush.h>
>  
> -static void cache_loop(struct page *page, const unsigned int reg)
> +static inline void cache_loop(struct page *page, const unsigned int reg)
>  {
>  	unsigned long paddr = page_to_pfn(page) << PAGE_SHIFT;
>  	unsigned long line = paddr & ~(L1_CACHE_BYTES - 1);
> -- 
> 2.17.1
>