linux-kernel - Re: [PATCH] drm/meson: venc: dmt mode must use encp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Nov 2018 09:35:04 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Jorge Ramirez-Ortiz <jramirez@...libre.com>, airlied@...ux.ie,
        carlo@...one.org, khilman@...libre.com
Cc:     dri-devel@...ts.freedesktop.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/meson: venc: dmt mode must use encp

On 12/11/2018 19:41, Jorge Ramirez-Ortiz wrote:
> From: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@...il.com>
> 
> The video mode for DMT is only populated to support encp.
> 
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@...il.com>
> ---
>  drivers/gpu/drm/meson/meson_venc.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 514245e..acbbad3 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -854,6 +854,13 @@ void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
>  	unsigned int sof_lines;
>  	unsigned int vsync_lines;
>  
> +	/* Use VENCI for 480i and 576i and double HDMI pixels */
> +	if (mode->flags & DRM_MODE_FLAG_DBLCLK) {
> +		hdmi_repeat = true;
> +		use_enci = true;
> +		venc_hdmi_latency = 1;
> +	}
> +
>  	if (meson_venc_hdmi_supported_vic(vic)) {
>  		vmode = meson_venc_hdmi_get_vic_vmode(vic);
>  		if (!vmode) {
> @@ -865,13 +872,7 @@ void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
>  	} else {
>  		meson_venc_hdmi_get_dmt_vmode(mode, &vmode_dmt);
>  		vmode = &vmode_dmt;
> -	}
> -
> -	/* Use VENCI for 480i and 576i and double HDMI pixels */
> -	if (mode->flags & DRM_MODE_FLAG_DBLCLK) {
> -		hdmi_repeat = true;
> -		use_enci = true;
> -		venc_hdmi_latency = 1;
> +		use_enci = false;
>  	}
>  
>  	/* Repeat VENC pixels for 480/576i/p, 720p50/60 and 1080p50/60 */
> 

Thanks !

Acked-by: Neil Armstrong <narmstrong@...libre.com>

I'll apply to drm-misc-fixes !

Neil