linux-kernel - Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Nov 2018 17:06:59 -0800
From:   Joe Perches <joe@...ches.com>
To:     Arnold Chand <arnold.chand@...il.com>,
        "eric@...olt.net" <eric@...olt.net>
Cc:     "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed
 warnings, checks

On Mon, 2018-11-12 at 19:45 -0500, Arnold Chand wrote:
> Corrected warnings and checks provided by scripts/checkpatch.pl which
> includes: alignment of parenthesis, lines over 80 characters and mutex
> definition without comment.
[]
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
[]
> @@ -162,7 +163,8 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
>  	mutex_lock(&chip->audio_mutex);
>  
>  	for (i = 0; i < 4; i++)
> -		val |= (unsigned int)ucontrol->value.iec958.status[i] << (i * 8);
> +		val |= (unsigned int)ucontrol->value.iec958.status[i] <<
> +		       (i * 8);

Perhaps this should be

	val = get_unaligned_be32(ucontrol->value.iec958.status);