linux-kernel - Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181113101701.GB10502@zn.tnic>
Date:   Tue, 13 Nov 2018 11:17:01 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        zhong.weidong@....com.cn, bp@...e.de
Subject: Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

On Tue, Nov 13, 2018 at 09:56:29AM +0800, Yi Wang wrote:
> We get a warning when building kernel with W=1:
> arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes]
>  void __init init_IRQ(void)
>              ^
> 
> Add the missing declaration in head file to fix this.
> 
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> ---
>  arch/x86/include/asm/irq.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/include/asm/irq.h b/arch/x86/include/asm/irq.h
> index 2395bb7..399a9c5 100644
> --- a/arch/x86/include/asm/irq.h
> +++ b/arch/x86/include/asm/irq.h
> @@ -41,6 +41,8 @@ static inline int irq_canonicalize(int irq)
>  
>  extern void init_ISA_irqs(void);
>  
> +extern void __init init_IRQ(void);
> +
>  #ifdef CONFIG_X86_LOCAL_APIC
>  void arch_trigger_cpumask_backtrace(const struct cpumask *mask,
>  				    bool exclude_self);
> -- 

I'm not sure we should do one patch per warning - that's too granulary.
What I did earlier was this:

make allmodconfig
make W=1 arch/x86/kernel/apic/

and then looked at all those -Wmissing-prototypes warnings.

Once I've fixed them, I commit the result as a

  x86/apic: Fix -Wmissing-prototypes warnings

and this way it is more or less per subsystem or folder or whatever,
which still keeps the amount of patches sane for further handling.

Now, I did some fixes here so I'd suggest you do all your patches ontop
of tip/master after merging this branch into it:

https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=tip-ras-core

I'll push it into tip the next days.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.