linux-kernel - Re: [PATCH] fork: Fix two -Wmissing-prototypes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cba61508-3e50-f8df-d75a-37d2e41a17c4@rasmusvillemoes.dk>
Date:   Tue, 13 Nov 2018 11:26:47 +0100
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Yi Wang <wang.yi59@....com.cn>, tglx@...utronix.de
Cc:     mingo@...hat.com, bp@...en8.de, hpa@...or.com, x86@...nel.org,
        keescook@...omium.org, luto@...capital.net, wad@...omium.org,
        konrad.wilk@...cle.com, dhowells@...hat.com,
        linux-kernel@...r.kernel.org, riel@...hat.com,
        viro@...IV.linux.org.uk, zhong.weidong@....com.cn
Subject: Re: [PATCH] fork: Fix two -Wmissing-prototypes warnings

On 13/11/2018 08.26, Yi Wang wrote:
> We get two warning when building kernel with W=1:
> kernel/fork.c:167:13: warning: no previous prototype for ‘arch_release_thread_stack’ [-Wmissing-prototypes]
> kernel/fork.c:779:13: warning: no previous prototype for ‘fork_init’ [-Wmissing-prototypes]

I think you should also remove the "manual" declarations from the .c
files that call the function, in this case fork_init() in  init/main.c;
otherwise there's no guarantee that those translation units actually
include the header that contain the proper declaration.

arch_release_thread_stack can probably just be removed completely after
the recent arch cleanup, since bb9d81264 (arch: remove tile port) no
arch seems to implement it.

Rasmus