linux-kernel - Re: [PATCH -next] drm/sti: remove set but not used variable 'priv'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+M3ks56PBoH3_H4a-DPKooGwx41T=K9XW5KhdRSTwRCYyOXGw@mail.gmail.com>
Date:   Tue, 13 Nov 2018 12:09:10 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     yuehaibing@...wei.com
Cc:     Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/sti: remove set but not used variable 'priv'

Le sam. 10 nov. 2018 à 03:48, YueHaibing <yuehaibing@...wei.com> a écrit :
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/sti/sti_crtc.c: In function 'sti_crtc_vblank_cb':
> drivers/gpu/drm/sti/sti_crtc.c:255:22: warning:
>  variable 'priv' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
>   9e1f05b28009 ("drm/sti: rename files and functions")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied on drm-misc-next.

Thanks,
Benjamin

> ---
>  drivers/gpu/drm/sti/sti_crtc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index 61c2379..ed76e52e 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -252,10 +252,8 @@ int sti_crtc_vblank_cb(struct notifier_block *nb,
>         struct sti_compositor *compo;
>         struct drm_crtc *crtc = data;
>         struct sti_mixer *mixer;
> -       struct sti_private *priv;
>         unsigned int pipe;
>
> -       priv = crtc->dev->dev_private;
>         pipe = drm_crtc_index(crtc);
>         compo = container_of(nb, struct sti_compositor, vtg_vblank_nb[pipe]);
>         mixer = compo->mixer[pipe];
>
>
>