lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Nov 2018 16:09:40 -0800 From: Brian Norris <briannorris@...omium.org> To: Alexander Kapshuk <alexander.kapshuk@...il.com> Cc: sky@...ki.is, schwab@...ux-m68k.org, Masahiro Yamada <yamada.masahiro@...ionext.com>, Douglas Anderson <dianders@...omium.org>, Guenter Roeck <linux@...ck-us.net>, lists@...dbynature.de, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks On Mon, Nov 12, 2018 at 10:42:26AM +0200, Alexander Kapshuk wrote: > An even simpler approach would be: > > { > git --no-optional-locks status -uno --porcelain 2>/dev/null || > git diff-index --name-only HEAD > } | grep -qv scripts/package && > printf '%s' -dirty > > Sample run: > cmd > sh: cmd: command not found > > { > cmd 2>/dev/null || > date > } | grep -q 2018 && > printf '%s' ok > ok You lose accuracy here, because now you're skipping any line that contains 'scripts/package', which would include, e.g., paths like tools/some/other-scripts/package Maybe if the grep expression were more like this? grep -qv '^\(.. \)\?scripts/package' I think it'd be safe enough to ignore paths that start with two characters and a space, like: xy scripts/package x/ scripts/package Brian
Powered by blists - more mailing lists