linux-kernel - Re: [PATCH] scsi: libsas: Remove pcidev reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da1e7856fbb1c107edea42c03591161a5e808978.camel@perches.com>
Date:   Tue, 13 Nov 2018 07:26:55 -0800
From:   Joe Perches <joe@...ches.com>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH] scsi: libsas: Remove pcidev reference

On Tue, 2018-11-13 at 13:38 +0000, John Garry wrote:
> On 12/11/2018 19:52, Joe Perches wrote:
> > On Mon, 2018-11-12 at 19:31 +0000, John Garry wrote:
> > > On 12/11/2018 18:58, Joe Perches wrote:
> > > > > > +#define pr_fmt(fmt) "sas: " fmt
[]
> > > > It also might useful to use the common debugging
> > > > mechanisms and convert SAS_DPRINTK to pr_debug
> > > > which would use the same #define pr_fmt.
{}
> We have almost 100 references to SAS_DPRINTK. So when we replace with 
> pr_debug, we will frequently have to realign the indentation. I'm 
> beginning to think it's not worth the churn to remove SAS_DPRINTK.

or just convert the #define

> However, with regards to using pr_debug(), there are loops to jump 
> through to ensure any output at all:
> - ensure DEBUG is defined or DYNAMIC DEBUG enabled

True

> - ensure current loglevel is high enough

That's already the case.

> Having said that, there are actually lots of logs in libsas where debug 
> level is too low (at pr_debug), and these could be upgraded.
> 
> So I think I will just go through the code and revise these levels.

Nice, thanks