linux-kernel - Re: [PATCH] hwmon (lm63) Do not overwrite data->kind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181113171249.GA21521@roeck-us.net>
Date:   Tue, 13 Nov 2018 09:12:49 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon (lm63) Do not overwrite data->kind

On Mon, Nov 12, 2018 at 08:36:56PM -0800, Nicolin Chen wrote:
> According to the code right before the removed line, data->kind
> should be either from DT or from id pointer. So there shouldn't
> be an additional overwriting after the if-else statement.
> 
> So this patch just removes the overwriting line.
> 
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
> Guenter,
>     I have not really tested this change but still sent it out
>     since it looks obvious. Please feel free to drop it if you
>     have concern at an untested change. Thanks.

Good find. You are right, the patch introducing the DT code didn't
really do anything. Given that no one (including me) noticed that
commit b25f663b91f1a was effectively a no-op, I'll queue this up
for the next kernel release.

Thanks,
Guenter

> 
>  drivers/hwmon/lm63.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
> index 4c1770920d29..eac54b9cdeec 100644
> --- a/drivers/hwmon/lm63.c
> +++ b/drivers/hwmon/lm63.c
> @@ -1120,7 +1120,6 @@ static int lm63_probe(struct i2c_client *client,
>  		data->kind = (enum chips)of_device_get_match_data(&client->dev);
>  	else
>  		data->kind = id->driver_data;
> -	data->kind = id->driver_data;
>  	if (data->kind == lm64)
>  		data->temp2_offset = 16000;
>  
> -- 
> 2.17.1
>