linux-kernel - Re: [PATCH] clk: qcom: gcc: Fix board clock node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <154212977367.88331.1550842985008389721@swboyd.mtv.corp.google.com>
Date:   Tue, 13 Nov 2018 09:22:53 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Taniya Das <tdas@...eaurora.org>, Vinod Koul <vkoul@...nel.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc: Fix board clock node name

Quoting Taniya Das (2018-11-10 18:12:28)
> Hello Vinod,
> 
> On 11/9/2018 3:20 PM, Vinod Koul wrote:
> > Device tree node name are not supposed to have "_" in them so fix the
> > node name use of xo_board to xo-board
> > 
> > Fixes: 652f1813c113 ("clk: qcom: gcc: Add global clock controller driver for QCS404")
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> > 
> > Steve: RobH pointed this on DTS patches, would be great if you can pick this
> > as a fix
> > 
> >   drivers/clk/qcom/gcc-qcs404.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> > index e4ca6a45f313..ef1b267cb058 100644
> > --- a/drivers/clk/qcom/gcc-qcs404.c
> > +++ b/drivers/clk/qcom/gcc-qcs404.c
> > @@ -265,7 +265,7 @@ static struct clk_fixed_factor cxo = {
> >       .div = 1,
> >       .hw.init = &(struct clk_init_data){
> >               .name = "cxo",
> > -             .parent_names = (const char *[]){ "xo_board" },
> > +             .parent_names = (const char *[]){ "xo-board" },
> >               .num_parents = 1,
> >               .ops = &clk_fixed_factor_ops,
> >       },
> > 
> 
> This fixed clock needs to be removed, once the RPM<->SMD clocks are 
> added. Why not have this clock part of the device Tree?
> 

If the clk needs to be removed at some point, then putting it into DT
instead of leaving it in the driver is the wrong direction to take. We
don't want to have to change DT as often as we change driver code.