linux-kernel - Re: [PATCH v3] cpufreq: ti-cpufreq: Only register platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Nov 2018 18:58:53 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Dave Gerlach <d-gerlach@...com>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Keerthy J <j-keerthy@...com>, Tero Kristo <t-kristo@...com>,
        Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v3] cpufreq: ti-cpufreq: Only register platform_device
 when supported

On Tue, Nov 13, 2018 at 11:39:12AM -0600, Dave Gerlach wrote:
> Currently the ti-cpufreq driver blindly registers a 'ti-cpufreq' to force
> the driver to probe on any platforms where the driver is built in.
> However, this should only happen on platforms that actually can make use
> of the driver. There is already functionality in place to match the
> SoC compatible so let's factor this out into a separate call and
> make sure we find a match before creating the ti-cpufreq platform device.
> 
> Reviewed-by: Johan Hovold <johan@...nel.org>
> Signed-off-by: Dave Gerlach <d-gerlach@...com>
> ---
> v2->v3: Use platform_device_register_resndata to pass match data to probe to
> 	to avoid matching again in probe.
> 
> 	v2: https://patchwork.kernel.org/patch/10574535/
> 

>  static int ti_cpufreq_init(void)
>  {
> -	platform_device_register_simple("ti-cpufreq", -1, NULL, 0);
> +	const struct of_device_id *match;
> +
> +	/* Check to ensure we are on a compatible platform */
> +	match = ti_cpufreq_match_node();
> +	if (match)
> +		platform_device_register_resndata(NULL, "ti-cpufreq", -1, NULL,
> +						  0, match,
> +						  sizeof(*match));

platform_device_register_data()?

>  	return 0;
>  }
>  module_init(ti_cpufreq_init);

Johan