linux-kernel - Re: Memory hotplug softlock issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a6c6d6b-ebcd-8bfa-d6e0-4312bfe86586@redhat.com>
Date:   Wed, 14 Nov 2018 09:18:09 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Baoquan He <bhe@...hat.com>, linux-mm@...ck.org
Cc:     linux-kernel@...r.kernel.org, mhocko@...e.com,
        akpm@...ux-foundation.org, aarcange@...hat.com
Subject: Re: Memory hotplug softlock issue

On 14.11.18 08:09, Baoquan He wrote:
> Hi,
> 
> Tested memory hotplug on a bare metal system, hot removing always
> trigger a lock. Usually need hot plug/unplug several times, then the hot
> removing will hang there at the last block. Surely with memory pressure
> added by executing "stress -m 200".
> 
> Will attach the log partly. Any idea or suggestion, appreciated. 
> 
> Thanks
> Baoquan
> 

Code seems to be waiting for the mem_hotplug_lock in read.
We hold mem_hotplug_lock in write whenever we online/offline/add/remove
memory. There are two ways to trigger offlining of memory:

1. Offlining via "cat offline > /sys/devices/system/memory/memory0/state"

This always properly took the mem_hotplug_lock. Nothing changed

2. Offlining via "cat 0 > /sys/devices/system/memory/memory0/online"

This didn't take the mem_hotplug_lock and I fixed that for this release.

So if you were testing with 1., you should have seen the same error
before this release (unless there is something else now broken in this
release).

The real question is, however, why offlining of the last block doesn't
succeed. In __offline_pages() we basically have an endless loop (while
holding the mem_hotplug_lock in write). Now I consider this piece of
code very problematic (we should automatically fail after X
attempts/after X seconds, we should not ignore -ENOMEM), and we've had
other BUGs whereby we would run into an endless loop here (e.g. related
to hugepages I guess).

You mentioned memory pressure, if our host is under memory pressure we
can easily trigger running into an endless loop there, because we
basically ignore -ENOMEM e.g. when we cannot get a page to migrate some
memory to be offlined. I assume this is the case here.
do_migrate_range() could be the bad boy if it keeps failing forever and
we keep retrying.

-- 

Thanks,

David / dhildenb