linux-kernel - Re: [PATCH] reset: Add reset_control_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Nov 2018 10:26:01 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>, uli@...nd.eu
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Auger Eric <eric.auger@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        KVM list <kvm@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] reset: Add reset_control_get_count()

On Wed, 2018-11-14 at 09:58 +0100, Geert Uytterhoeven wrote:
> On Wed, Nov 14, 2018 at 7:30 AM Ulrich Hecht <uli@...nd.eu> wrote:
> > On November 13, 2018 at 1:47 PM Geert Uytterhoeven <geert+renesas@...der.be> wrote:
> > > Currently the reset core has internal support for counting the number of
> > > resets for a device described in DT.  Generalize this to devices using
> > > lookup resets, and export it for public use.
> > > 
> > > This will be used by generic drivers that need to be sure a device is
> > > controlled by a single, dedicated reset line (e.g. vfio-platform).
> > > 
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > > ---
> > > See https://lore.kernel.org/lkml/1539003437.11512.20.camel@pengutronix.de/
> > > for the rationale to ensure a single, dedicated reset line.
> > > 
> > >  drivers/reset/core.c  | 41 +++++++++++++++++++++++++++++++++++++++++
> > >  include/linux/reset.h |  7 +++++++
> > >  2 files changed, 48 insertions(+)
> > > 
> > > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > > index 654e20ff2d5da9d4..c32b755ec373c338 100644
> > > --- a/drivers/reset/core.c
> > > +++ b/drivers/reset/core.c
> > > +/**
> > > + * of_reset_control_get_count - Count number of resets available with a device
> > 
> > Should be "reset_control_get_count", without of_ prefix.
> 
> Oops, thanks for catching!
> 
> Philipp: Do you want a v2 or incremental, or can you fix it up yourself?

No need, I'll fix it up.

thanks
Philipp