linux-kernel - Re: [PATCH v3] mm: Create the new vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0EAE1409-DF80-4A9A-8936-C6E9BC7C9604@oracle.com>
Date:   Wed, 14 Nov 2018 02:59:11 -0700
From:   William Kucharski <william.kucharski@...cle.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>, vbabka@...e.cz,
        riel@...hat.com, rppt@...ux.ibm.com, Linux-MM <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mm: Create the new vm_fault_t type



> On Nov 13, 2018, at 10:13 PM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> 
> On Tue, Nov 6, 2018 at 5:33 PM Souptick Joarder <jrdr.linux@...il.com> wrote:
>> 
>> Page fault handlers are supposed to return VM_FAULT codes,
>> but some drivers/file systems mistakenly return error
>> numbers. Now that all drivers/file systems have been converted
>> to use the vm_fault_t return type, change the type definition
>> to no longer be compatible with 'int'. By making it an unsigned
>> int, the function prototype becomes incompatible with a function
>> which returns int. Sparse will detect any attempts to return a
>> value which is not a VM_FAULT code.
>> 
>> VM_FAULT_SET_HINDEX and VM_FAULT_GET_HINDEX values are changed
>> to avoid conflict with other VM_FAULT codes.
>> 
>> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> 
> Any further comment on this patch ?

Reviewed-by: William Kucharski <william.kucharski@...cle.com>