linux-kernel - [PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181114165025.2293-1-christophe.jaillet@wanadoo.fr>
Date:   Wed, 14 Nov 2018 17:50:25 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com
Cc:     linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: [PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Commit 22652ba72453 has modified more than what is said in the commit
message and error should be propagated.

Fixes: 22652ba72453 ("rtc: stop validating rtc_time in .read_time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
---
Not sure that the Fixes tag is the right one.
It is related, but not 100% accurate IMHO.
---
 drivers/rtc/rtc-max8997.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c
index 08c661a332ec..20e50d9fdf88 100644
--- a/drivers/rtc/rtc-max8997.c
+++ b/drivers/rtc/rtc-max8997.c
@@ -215,7 +215,7 @@ static int max8997_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 out:
 	mutex_unlock(&info->lock);
-	return 0;
+	return ret;
 }
 
 static int max8997_rtc_stop_alarm(struct max8997_rtc_info *info)
-- 
2.17.1