linux-kernel - Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Nov 2018 22:22:39 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Luis Oliveira <luis.oliveira@...opsys.com>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        joao.pinto@...opsys.com, festevam@...il.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Thierry Reding <treding@...dia.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Todor Tomov <todor.tomov@...aro.org>
Subject: Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

Hi Luis,

Thank you for the patch.

On Friday, 19 October 2018 15:52:26 EET Luis Oliveira wrote:
> Add the Synopsys MIPI CSI-2 controller driver. This
> controller driver is divided in platform dependent functions
> and core functions. It also includes a platform for future
> DesignWare drivers.
> 
> Signed-off-by: Luis Oliveira <lolivei@...opsys.com>
> ---
> Changelog
> v2-V3
> - exposed IPI settings to userspace

Could you please explain why you need this and can't use standard APIs ? 
Custom sysfs attributes are needed, they need to be documented in 
Documentation/ABI/.

> - fixed headers
> 
>  MAINTAINERS                              |  11 +
>  drivers/media/platform/dwc/Kconfig       |  30 +-
>  drivers/media/platform/dwc/Makefile      |   2 +
>  drivers/media/platform/dwc/dw-csi-plat.c | 699 ++++++++++++++++++++++++++++
>  drivers/media/platform/dwc/dw-csi-plat.h |  77 ++++
>  drivers/media/platform/dwc/dw-mipi-csi.c | 494 ++++++++++++++++++++++
>  drivers/media/platform/dwc/dw-mipi-csi.h | 202 +++++++++
>  include/media/dwc/dw-mipi-csi-pltfrm.h   | 102 +++++
>  8 files changed, 1616 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/media/platform/dwc/dw-csi-plat.c
>  create mode 100644 drivers/media/platform/dwc/dw-csi-plat.h
>  create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.c
>  create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.h
>  create mode 100644 include/media/dwc/dw-mipi-csi-pltfrm.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index da2e509..fd5f1fc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14032,6 +14032,16 @@ S:	Maintained
>  F:	drivers/dma/dwi-axi-dmac/
>  F:	Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
> 
> +SYNOPSYS DESIGNWARE MIPI CSI-2 HOST VIDEO PLATFORM
> +M:	Luis Oliveira <luis.oliveira@...opsys.com>
> +L:	linux-media@...r.kernel.org
> +T:	git git://linuxtv.org/media_tree.git
> +S:	Maintained
> +F:	drivers/media/platform/dwc
> +F:	include/media/dwc/dw-mipi-csi-pltfrm.h
> +F:	Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt
> +F:	Documentation/devicetree/bindings/phy/snps,dphy-rx.txt

These two lines belong to patches 1/4 and 3/4. Doesn't checkpatch.pl warn 
about this ? Now that I mentioned checkpatch.pl, I tried running it on this 
series, and it generates a fair number of warnings and errors. Could you 
please fix them ?

> +
>  SYNOPSYS DESIGNWARE DMAC DRIVER
>  M:	Viresh Kumar <vireshk@...nel.org>
>  R:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> @@ -16217,3 +16227,4 @@ T:	git
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git S:	Buried
> alive in reporters
>  F:	*
>  F:	*/
> +

Stray new line.

[snip]

-- 
Regards,

Laurent Pinchart