linux-kernel - Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181114205855.GF11416@localhost.localdomain>
Date:   Wed, 14 Nov 2018 13:58:55 -0700
From:   Keith Busch <keith.busch@...el.com>
To:     Alex_Gagniuc@...lteam.com
Cc:     helgaas@...nel.org, oohall@...il.com, gregkh@...uxfoundation.org,
        mr.nuke.me@...il.com, linux-pci@...r.kernel.org,
        Austin.Bolen@...l.com, Shyam.Iyer@...l.com,
        linux-kernel@...r.kernel.org, jonathan.derrick@...el.com,
        lukas@...ner.de, ruscur@...sell.cc, sbobroff@...ux.ibm.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is
 disconnected

On Wed, Nov 14, 2018 at 08:52:10PM +0000, Alex_Gagniuc@...lteam.com wrote:
> But it does in portdrv_core.c:
> 
> 	if (dev->aer_cap && pci_aer_available() &&
> 	    (pcie_ports_native || host->native_aer)) {
> 		services |= PCIE_PORT_SERVICE_AER;
> 
> That flag later creates a pcie device that allows aerdrv to attach to.

Oh, right. I saw negotiate_os_control() just uses a stack variable for
the _OSC response, but if I had looked one level deeper, I'd see it
cached in a different structure.