linux-kernel - Re: [PATCH][next] block: clean up dead code that is now redundant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ec214ef-d434-df9a-2bb3-9bda2ef55fbe@kernel.dk>
Date:   Wed, 14 Nov 2018 15:20:07 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Colin King <colin.king@...onical.com>, linux-block@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] block: clean up dead code that is now redundant

On 11/14/18 3:17 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The boolean next_sorted is set to false and is never changed, hence
> the code that checks if it is true is dead code and can now be
> removed.  This dead code occurred from a previous commit that cleaned
> up the elevator and removed the setting of next_sorted to true.

Ah nice, it's also the last "user" of q->nr_sorted, so that one can
go away as well.

-- 
Jens Axboe