linux-kernel - Re: [PATCH 1/2] dt-bindings: clk: Add bindings for Fixed MMIO clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <154223498711.88331.11553475442681784637@swboyd.mtv.corp.google.com>
Date:   Wed, 14 Nov 2018 14:36:27 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     "mark.rutland@....com" <mark.rutland@....com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Janek Kotas <jank@...ence.com>
Cc:     "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: clk: Add bindings for Fixed MMIO clock

Quoting Janek Kotas (2018-11-14 07:24:21)
> +
> +Required properties:
> +- compatible : shall be "fixed-mmio-clock".
> +- #clock-cells : from common clock binding; shall be set to 0.
> +- reg : Address and length of the clock value register set.
> +
> +Optional properties:
> +- clock-output-names : From common clock binding.
> +
> +Example:
> +sysclock: sysclock@...20004 {
> +       #clock-cells = <0>;
> +       compatible = "fixed-mmio-clock";
> +       reg = <0xfd020004 0x4>;

Unfortunately this looks wrong and seems to be a way to split up a
hardware IP block into many little DT nodes to describe clks inside of a
clock controller. We don't do that style of clk drivers anymore.