linux-kernel - Re: [PATCH][next] reset: fix null pointer dereference on dev by dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1542274394.4915.6.camel@pengutronix.de>
Date:   Thu, 15 Nov 2018 10:33:14 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Colin King <colin.king@...onical.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] reset: fix null pointer dereference on dev by
 dev_name

Hi Colin,

On Wed, 2018-11-14 at 21:49 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The call to dev_name will dereference dev, however, dev is later
> being null checked, so there is a possibility of a null pointer
> dereference on dev by the call to dev_name. Fix this by null
> checking dev first before the call to dev_name
> 
> Detected by CoverityScan, CID#1475475 ("Dereference before null check")
> 
> Fixes: 2a6cb2b1d83b ("reset: Add reset_control_get_count()")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thank you, applied to reset/next.

regards
Philipp