linux-kernel - Re: [PATCH AUTOSEL 4.19 32/73] ARM: dts: imx6sx-sdb: Fix enet phy regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81c6426b186174a852cf615b4321f4283d9b5fd7.camel@nxp.com>
Date:   Thu, 15 Nov 2018 10:39:44 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     "sashal@...nel.org" <sashal@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        Andy Duan <fugang.duan@....com>
Subject: Re: [PATCH AUTOSEL 4.19 32/73] ARM: dts: imx6sx-sdb: Fix enet phy
 regulator

On Wed, 2018-11-14 at 17:21 -0500, Sasha Levin wrote:
> From: Leonard Crestez <leonard.crestez@....com>
> 
> [ Upstream commit 1ad9fb750a104f51851c092edd7b3553f0218428 ]
> 
> Bindings for "fixed-regulator" only explicitly support "gpio" property,
> not "gpios". Fix by correcting the property name.
> 
> The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power
> cycle, this can be handled by the phy-reset-gpios property. Sadly this
> is not handled on suspend: the fec driver turns phy-supply off but
> doesn't assert phy-reset-gpios again on resume.
> 
> Since additional phy-level work is required to support powering off the
> phy in suspend fix the problem by just marking the regulator as
> "boot-on" "always-on" so that it's never turned off. This behavior is
> equivalent to older releases.
> 
> Keep the phy-reset-gpios property on fec anyway because it is a correct
> description of board design.
> 
> This issue was exposed by commit efdfeb079cc3 ("regulator: fixed:
> Convert to use GPIO descriptor only") which causes the "gpios" property
> to also be parsed. Before that commit the "gpios" property had no
> effect, PHY reset was only handled in the the bootloader.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@....com>
> Signed-off-by: Shawn Guo <shawnguo@...nel.org>

This is something of a workaround for gpio core changes in 4.20 and
there is no need for it in older releases.

I don't think you should backport this.

--
Regards,
Leonard