linux-kernel - Re: [PATCH -next] i3c: master: Remove set but not used variable 'old_i3c_scl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Nov 2018 11:41:16 +0100
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] i3c: master: Remove set but not used variable
 'old_i3c_scl_lim'

On Wed, 14 Nov 2018 06:10:47 +0000
YueHaibing <yuehaibing@...wei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/i3c/master/i3c-master-cdns.c: In function 'cdns_i3c_master_do_daa':
> drivers/i3c/master/i3c-master-cdns.c:1137:16: warning:
>  variable 'old_i3c_scl_lim' set but not used [-Wunused-but-set-variable]
> 
> It never used since introdution in commit
>   acfab7d324b2 ("i3c: master: Add driver for Cadence IP")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.

Thanks,

Boris

> ---
>  drivers/i3c/master/i3c-master-cdns.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> index ad40162..e828921 100644
> --- a/drivers/i3c/master/i3c-master-cdns.c
> +++ b/drivers/i3c/master/i3c-master-cdns.c
> @@ -1133,7 +1133,6 @@ static void cdns_i3c_master_upd_i3c_scl_lim(struct cdns_i3c_master *master)
>  static int cdns_i3c_master_do_daa(struct i3c_master_controller *m)
>  {
>  	struct cdns_i3c_master *master = to_cdns_i3c_master(m);
> -	unsigned long old_i3c_scl_lim;
>  	u32 olddevs, newdevs;
>  	int ret, slot;
>  	u8 addrs[MAX_DEVS] = { };
> @@ -1165,9 +1164,6 @@ static int cdns_i3c_master_do_daa(struct i3c_master_controller *m)
>  	newdevs = readl(master->regs + DEVS_CTRL) & DEVS_CTRL_DEVS_ACTIVE_MASK;
>  	newdevs &= ~olddevs;
>  
> -	/* Save the old limitation before add devices. */
> -	old_i3c_scl_lim = master->i3c_scl_lim;
> -
>  	/*
>  	 * Clear all retaining registers filled during DAA. We already
>  	 * have the addressed assigned to them in the addrs array.
> 
> 
>