linux-kernel - Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'ring'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e67a5b3-6a0e-6c3a-af90-2125713f522f@huawei.com>
Date:   Thu, 15 Nov 2018 19:56:31 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     "Huang, Ray" <Ray.Huang@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "Liu, Shaoyun" <Shaoyun.Liu@....com>,
        "Francis, David" <David.Francis@....com>,
        "Xu, Feifei" <Feifei.Xu@....com>, "Gao, Likun" <Likun.Gao@....com>
CC:     "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'ring'


On 2018/11/15 19:49, Huang, Ray wrote:
>> -----Original Message-----
>> From: YueHaibing [mailto:yuehaibing@...wei.com]
>> Sent: Thursday, November 15, 2018 6:52 PM
>> To: Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian
>> <Christian.Koenig@....com>; Zhou, David(ChunMing)
>> <David1.Zhou@....com>; airlied@...ux.ie; Liu, Shaoyun
>> <Shaoyun.Liu@....com>; Francis, David <David.Francis@....com>; Huang,
>> Ray <Ray.Huang@....com>; Xu, Feifei <Feifei.Xu@....com>; Gao, Likun
>> <Likun.Gao@....com>
>> Cc: YueHaibing <yuehaibing@...wei.com>; amd-gfx@...ts.freedesktop.org;
>> dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; kernel-
>> janitors@...r.kernel.org
>> Subject: [PATCH -next] drm/amdgpu: remove set but not used variable 'ring'
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c: In function
>> 'psp_v10_0_ring_stop':
>> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c:230:19: warning:
>>  variable 'ring' set but not used [-Wunused-but-set-variable]
>>
>> It not used since commit
>> 4ef72453311a ("drm/amdgpu: added api for stopping psp ring (v2)")
> 
> Thanks, please also remove the similar code in psp_v3_1. 
> With that updates, patch is Reviewed-by: Huang Rui <ray.huang@....com>
> 

Ok, will send v2.

>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
>> b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
>> index 295c220..d78b430 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
>> @@ -240,12 +240,9 @@ static int psp_v10_0_ring_stop(struct psp_context
>> *psp,
>>  			       enum psp_ring_type ring_type)  {
>>  	int ret = 0;
>> -	struct psp_ring *ring;
>>  	unsigned int psp_ring_reg = 0;
>>  	struct amdgpu_device *adev = psp->adev;
>>
>> -	ring = &psp->km_ring;
>> -
>>  	/* Write the ring destroy command to C2PMSG_64 */
>>  	psp_ring_reg = 3 << 16;
>>  	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_64, psp_ring_reg);
>>
>>
>>
>>
> 
> 
> .
>