linux-kernel - Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a81dda8e-d767-344a-d728-cbda4c616e84@kernel.org>
Date:   Thu, 15 Nov 2018 10:23:43 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA



On 11/15/18 9:34 AM, Philipp Zabel wrote:
> Hi Dinh,
> 
> On Tue, 2018-11-13 at 12:50 -0600, Dinh Nguyen wrote:
>> @@ -120,7 +120,8 @@ static const struct reset_simple_devdata reset_simple_active_low = {
>>  };
>>  
>>  static const struct of_device_id reset_simple_dt_ids[] = {
>> -	{ .compatible = "altr,rst-mgr", .data = &reset_simple_socfpga },
>> +	{ .compatible = "altr,stratix10-rst-mgr", "altr,rst-mgr",
> 
> This should be
> 
> +       { .compatible = "altr,stratix10-rst-mgr",
> 
> instead. The rest looks good to me. If you are ok with this change, I
> can fix it up when applying.
> 

Sure..thanks,
Dinh