linux-kernel - Re: [PATCH 1/2] ASoC: ak4118: Add support for AK4118 S/PDIF transceiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJiuCccTwxA4Am=H5vMw9PBJQi_+ErSPEsT5C7PRpv_b6y9EPA@mail.gmail.com>
Date:   Thu, 15 Nov 2018 17:31:44 +0100
From:   Clément Péron <peron.clem@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Adrien Charruel <adrien.charruel@...ialet.com>
Subject: Re: [PATCH 1/2] ASoC: ak4118: Add support for AK4118 S/PDIF transceiver

Hi Mark,

On Wed, 14 Nov 2018 at 18:31, Mark Brown <broonie@...nel.org> wrote:
>
> On Wed, Nov 14, 2018 at 11:55:17AM +0100, Clément Péron wrote:
> > On Tue, 13 Nov 2018 at 23:51, Mark Brown <broonie@...nel.org> wrote:
> > > On Thu, Nov 08, 2018 at 01:49:33PM +0100, Clément Péron wrote:
>
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +/*
> > > > + * ak4118.c  --  Asahi Kasei ALSA Soc Audio driver
> > > > + *
>
> > > Please make the entire comment a C++ one so this looks more intentional.
>
> > I check from other files and also this article says :
> > "For normal C source files, the string will be a comment using the
> > "//" syntax; header files, instead, use traditional (/* */) comments
> > for reasons related to tooling"
> > https://lwn.net/Articles/739183/
>
> Right, and what I said was that you should make the entire comment a C++
> one which means that the magic line will be C++ as required.

Yes, sorry I was confused between C++ and C99,
Regards,
Clement