linux-kernel - Re: [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7db24e0-94fe-7875-c4a6-84d739ac185b@ti.com>
Date:   Thu, 15 Nov 2018 11:08:33 -0600
From:   "Andrew F. Davis" <afd@...com>
To:     Andreas Dannenberg <dannenberg@...com>,
        Mark Brown <broonie@...nel.org>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        Stephane Le Provost <stephane.leprovost@...iatek.com>
Subject: Re: [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value

On 11/15/18 11:01 AM, Andreas Dannenberg wrote:
> According to the current device datasheet (TI Lit # SLAS831D, revised
> March 2018) the value written to the device's PAGE register to trigger
> a complete register reset should be 0xfe, not 0xff. So go ahead and
> update to the correct value.
> 
> Reported-by: Stephane Le Provost <stephane.leprovost@...iatek.com>
> Tested-by: Stephane Le Provost <stephane.leprovost@...iatek.com>
> Signed-off-by: Andreas Dannenberg <dannenberg@...com>
> ---


Does 0xff not reset the device? If so then this is not just a typo but a
bug and this patch should have a fixes tag. Either way:

Acked-by: Andrew F. Davis <afd@...com>


>  sound/soc/codecs/pcm186x.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/pcm186x.h b/sound/soc/codecs/pcm186x.h
> index 2c6ba55bf394..bb3f0c42a1cd 100644
> --- a/sound/soc/codecs/pcm186x.h
> +++ b/sound/soc/codecs/pcm186x.h
> @@ -139,7 +139,7 @@ enum pcm186x_type {
>  #define PCM186X_MAX_REGISTER		PCM186X_CURR_TRIM_CTRL
>  
>  /* PCM186X_PAGE */
> -#define PCM186X_RESET			0xff
> +#define PCM186X_RESET			0xfe
>  
>  /* PCM186X_ADCX_INPUT_SEL_X */
>  #define PCM186X_ADC_INPUT_SEL_POL	BIT(7)
>