linux-kernel - Re: [PATCH] arch/sparc: Use kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Nov 2018 23:23:42 +0530
From:   Sabyasachi Gupta <sabyasachi.linux@...il.com>
To:     davem@...emloft.net, khandual@...ux.vnet.ibm.com
Cc:     Souptick Joarder <jrdr.linux@...il.com>,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Subject: Re: [PATCH] arch/sparc: Use kzalloc_node

On Sat, Nov 3, 2018 at 10:54 AM Sabyasachi Gupta
<sabyasachi.linux@...il.com> wrote:
>
> Replaced kmalloc_node + memset with kzalloc_node
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>

Any comment on this patch?

> ---
>  arch/sparc/kernel/iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sparc/kernel/iommu.c b/arch/sparc/kernel/iommu.c
> index 40d008b..05eb016 100644
> --- a/arch/sparc/kernel/iommu.c
> +++ b/arch/sparc/kernel/iommu.c
> @@ -108,10 +108,9 @@ int iommu_table_init(struct iommu *iommu, int tsbsize,
>         /* Allocate and initialize the free area map.  */
>         sz = num_tsb_entries / 8;
>         sz = (sz + 7UL) & ~7UL;
> -       iommu->tbl.map = kmalloc_node(sz, GFP_KERNEL, numa_node);
> +       iommu->tbl.map = kzalloc_node(sz, GFP_KERNEL, numa_node);
>         if (!iommu->tbl.map)
>                 return -ENOMEM;
> -       memset(iommu->tbl.map, 0, sz);
>
>         iommu_tbl_pool_init(&iommu->tbl, num_tsb_entries, IO_PAGE_SHIFT,
>                             (tlb_type != hypervisor ? iommu_flushall : NULL),
> --
> 2.7.4
>