linux-kernel - Re: [PATCH 1/1] net-next/hinic:fix three problems in HiNIC Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181115.095622.889070618474069350.davem@davemloft.net>
Date:   Thu, 15 Nov 2018 09:56:22 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xuechaojing@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        wulike1@...wei.com, chiqijun@...wei.com, fy.wang@...wei.com,
        tony.qu@...wei.com, luoshaokai@...wei.com
Subject: Re: [PATCH 1/1] net-next/hinic:fix three problems in HiNIC Driver

From: Xue Chaojing <xuechaojing@...wei.com>
Date: Thu, 15 Nov 2018 05:23:27 +0000

> This patch fixes these problems:
> 1. In order to improve performance, this patch add rx checksum offload
> for the HiNIC driver. Performance test(Iperf) shows more than 95%
> improvement in TCP streams.
> 2. In add_mac_addr(), if the MAC address is a muliticast address, it
> will not be set, which causes the network card fail to receive the
> multicast packet. This patch fixes this bug.
> 3. In rx_alloc_pkts(), there is a loop call of tasklet, which causes
> 100% cpu utilization, even no packets are being received. This patch
> fixes this bug.
> 
> Signed-off-by: Xue Chaojing <xuechaojing@...wei.com>

Each patch should do one thing.

Please don't combine multiple changes into one patch like this.

Post a proper patches series, one change per patch, with a proper
"[PATCH 0/N] " header posting preceeding the series.

Thanks.