linux-kernel - Re: [PATCH] arch/powerpc: Use dma_zalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Nov 2018 23:29:52 +0530
From:   Sabyasachi Gupta <sabyasachi.linux@...il.com>
To:     benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        joe@...ches.com, darren@...vens-zone.net, christophe.leroy@....fr,
        geoff@...radead.org
Cc:     Souptick Joarder <jrdr.linux@...il.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent

On Mon, Nov 5, 2018 at 8:58 AM Sabyasachi Gupta
<sabyasachi.linux@...il.com> wrote:
>
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>

Any comment on this patch?

> ---
>  arch/powerpc/platforms/pasemi/dma_lib.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/pasemi/dma_lib.c b/arch/powerpc/platforms/pasemi/dma_lib.c
> index 53384eb..d18d164 100644
> --- a/arch/powerpc/platforms/pasemi/dma_lib.c
> +++ b/arch/powerpc/platforms/pasemi/dma_lib.c
> @@ -255,15 +255,13 @@ int pasemi_dma_alloc_ring(struct pasemi_dmachan *chan, int ring_size)
>
>         chan->ring_size = ring_size;
>
> -       chan->ring_virt = dma_alloc_coherent(&dma_pdev->dev,
> +       chan->ring_virt = dma_zalloc_coherent(&dma_pdev->dev,
>                                              ring_size * sizeof(u64),
>                                              &chan->ring_dma, GFP_KERNEL);
>
>         if (!chan->ring_virt)
>                 return -ENOMEM;
>
> -       memset(chan->ring_virt, 0, ring_size * sizeof(u64));
> -
>         return 0;
>  }
>  EXPORT_SYMBOL(pasemi_dma_alloc_ring);
> --
> 2.7.4
>