linux-kernel - Re: linux-next: build warning after merge of the spi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 15 Nov 2018 11:26:31 -0800
From:   Mark Brown <broonie@...nel.org>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     sfr@...b.auug.org.au, linux-next@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the spi tree

On Thu, Nov 15, 2018 at 05:56:19PM +0200, Tomer Maimon wrote:
> Hi Mark and Stephen,
> 
> I saw the warning from the kbuilt, in this matter the ioread() function
> will call every time (and the val parameter will used) because rsize can be
> 1 or 2.
> 
> rsize = min(bytes_per_word(priv->bits_per_word), priv->rx_bytes);
> bytes_per_word(priv->bits_per_word)function return 1 or 2.
> npcm_pspi_recv()function will called only if parameter priv->rx_bytes is
> not 0.
> 
> please let me know if you think that I still need to modify the npcm_pspi_recv
> to fix kbuilt warning.

Please, it's going to create noise for people working on the kernel if
they get a spurious warning.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)