linux-kernel - Re: [PATCH] geneve: Add missing braces in addr6 initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181115.113501.2215768757973757171.davem@davemloft.net>
Date:   Thu, 15 Nov 2018 11:35:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     sbrivio@...hat.com, sd@...asysnail.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] geneve: Add missing braces in addr6 initializer

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon, 12 Nov 2018 15:12:48 -0700

> Clang warns:
> 
> drivers/net/geneve.c:428:29: error: suggest braces around initialization
> of subobject [-Werror,-Wmissing-braces]
>                 struct in6_addr addr6 = { 0 };
>                                           ^
>                                           {}
> 
> Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

And this makes GCC warn.

drivers/net/geneve.c: In function ‘geneve_udp_encap_err_lookup’:
drivers/net/geneve.c:428:27: warning: missing braces around initializer [-Wmissing-braces]
   struct in6_addr addr6 = { { 0 } };
                           ^
                               { }

（╯°□°）╯︵ ┻━┻