linux-kernel - Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGAzgsroEhcohssW8YUw_6otaLhUznXAE4P7jkd2HBA_W+V9_g@mail.gmail.com>
Date:   Thu, 15 Nov 2018 21:17:15 -0800
From:   "dbasehore ." <dbasehore@...omium.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        谢修鑫 <tony.xie@...k-chips.com>,
        Chris Zhong <zyw@...k-chips.com>, ayaka@...lik.info,
        "nickey.yang" <nickey.yang@...k-chips.com>,
        Shunqian Zheng <zhengsq@...k-chips.com>,
        klaus.goger@...obroma-systems.com,
        Brian Norris <briannorris@...omium.org>,
        enric.balletbo@...labora.com,
        Heiko Stübner <heiko@...ech.de>,
        Mark Rutland <mark.rutland@....com>, robh+dt@...nel.org
Subject: Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Thu, Nov 15, 2018 at 9:03 PM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Thu, Nov 15, 2018 at 4:42 PM Derek Basehore <dbasehore@...omium.org> wrote:
> >
> > This adds the xin32k clock to the RK3399 CPU. Even though it's not
> > directly used, muxes will end up traversing the entire clk tree on
> > calls to determine_rate if it doesn't exist.
> >
> > Signed-off-by: Derek Basehore <dbasehore@...omium.org>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > index 99e7f65c1779..6a32293982d0 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> > @@ -191,6 +191,13 @@
> >                 #clock-cells = <0>;
> >         };
> >
> > +       xin32k: xin32k {
>
> nit: xin32k is the name of the clock that rk3399 consumes.  It seems a
> little weird to name this node with that name.  Can you call this:
>
> ap_rtc_clk: ap-rtc-clk
>
> ...after the gru schematic?  You wouldn't change the
> clock-output-names, just the node name / label.
>
>
> > +               compatible = "fixed-clock";
> > +               clock-frequency = <32000>;
>
> I checked the datasheet for the 32K clock and it shows that this is a
> 32768 Hz clock, not a 32000 Hz one.  I also checked the rk808 clock
> driver (which is supposed to be compatible with rk3399) and it
> produces a 32768 clock.

Ok, sending out an updated patch that addresses these concerns.