linux-kernel - Re: [PATCH] crypto: ecc - check for invalid values in the key verification test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181116061601.zagzxvsoc6why5ep@gondor.apana.org.au>
Date:   Fri, 16 Nov 2018 14:16:01 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Vitaly Chikunov <vt@...linux.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ecc - check for invalid values in the key
 verification test

On Mon, Nov 05, 2018 at 11:36:18AM +0300, Vitaly Chikunov wrote:
> Currently used scalar multiplication algorithm (Matthieu Rivain, 2011)
> have invalid values for scalar == 1, n-1, and for regularized version
> n-2, which was previously not checked. Verify that they are not used as
> private keys.
> 
> Signed-off-by: Vitaly Chikunov <vt@...linux.org>
> ---
>  crypto/ecc.c | 42 ++++++++++++++++++++++++++----------------
>  1 file changed, 26 insertions(+), 16 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt