linux-kernel - Re: [alsa-devel] [PATCH v3 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <336ad4dd-6046-7386-4080-d3061d04d8c2@linaro.org>
Date:   Fri, 16 Nov 2018 09:21:42 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Daniel Baluta <daniel.baluta@...il.com>
Cc:     Mark Brown <broonie@...nel.org>, vkoul@...nel.org,
        Devicetree List <devicetree@...r.kernel.org>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        bgoswami@...eaurora.org, Takashi Iwai <tiwai@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>, rohitkr@...eaurora.org,
        srini@...nel.org
Subject: Re: [alsa-devel] [PATCH v3 1/5] ALSA: soc-compress: add support to
 snd_compr_set_runtime_buffer()

Thanks for your comments!

On 16/11/18 07:18, Daniel Baluta wrote:
> One minor comment:
> 
> <snip>
> 
>>          struct snd_compr_ops *ops;
>> +       struct snd_dma_buffer *dma_buffer_p;
> I don't think it is necessary to encode the type inside the name variable
> So, dma_buffer would sounds better to me then dma_buffer_p;
> 
>>          void *buffer;
> It is also consistent with this ^
> 
> <snip>
>> +static inline void snd_compr_set_runtime_buffer(
>> +                                       struct snd_compr_stream *substream,
>> +                                       struct snd_dma_buffer *bufp)
> Also buf instead of bufp here.

TBH, I followed what ./include/sound/pcm.h does!

--srini