linux-kernel - Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181116105738.GA21277@red-moon>
Date:   Fri, 16 Nov 2018 10:57:38 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Mario.Limonciello@...l.com
Cc:     mika.westerberg@...ux.intel.com, lukas@...ner.de,
        iommu@...ts.linux-foundation.org, joro@...tes.org,
        dwmw2@...radead.org, baolu.lu@...ux.intel.com, ashok.raj@...el.com,
        bhelgaas@...gle.com, rjw@...ysocki.net, jacob.jun.pan@...el.com,
        andreas.noever@...il.com, michael.jamet@...el.com,
        YehezkelShB@...il.com, ckellner@...hat.com,
        anthony.wong@...onical.com, linux-acpi@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices

On Thu, Nov 15, 2018 at 07:33:54PM +0000, Mario.Limonciello@...l.com wrote:
> 
> 
> > -----Original Message-----
> > From: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Sent: Thursday, November 15, 2018 1:01 PM
> > To: Lorenzo Pieralisi
> > Cc: Lukas Wunner; iommu@...ts.linux-foundation.org; Joerg Roedel; David
> > Woodhouse; Lu Baolu; Ashok Raj; Bjorn Helgaas; Rafael J. Wysocki; Jacob jun Pan;
> > Andreas Noever; Michael Jamet; Yehezkel Bernat; Christian Kellner; Limonciello,
> > Mario; Anthony Wong; linux-acpi@...r.kernel.org; linux-pci@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices
> > 
> > 
> > [EXTERNAL EMAIL]
> > 
> > On Thu, Nov 15, 2018 at 05:46:08PM +0000, Lorenzo Pieralisi wrote:
> > > Do you really need to parse it if the dev->is_thunderbolt check is enough ?
> > 
> > Yes, we need to parse it one way or another. dev->is_thunderbolt is
> > based on heuristics which do not apply anymore when the thing gets
> > integrated in the SoC.
> > 
> > The _DSD is there already (on existing systems) and is being used by
> > Windows so I don't understand why we cannot take advantage of it? Every
> > new system with Thunderbolt ports will have it.

We have different opinions on this, there is no point in me reiterating
it over and over, I am against the approach taken to solve this problem
first in defining the bindings outside the ACPI specifications and
second by acquiescing to what has been done so that it will be done
over and over again.

I will raise the point in the appropriate forum, it is up to Bjorn
and Rafael to decide on this patch.

Lorenzo