linux-kernel - Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Nov 2018 13:28:13 +0100
From:   Petr Tesarik <ptesarik@...e.com>
To:     Halil Pasic <pasic@...ux.ibm.com>
Cc:     Tony Krowiak <akrowiak@...ux.ibm.com>,
        Pierre Morel <pmorel@...ux.ibm.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for
 test_facility()

On Fri, 16 Nov 2018 13:20:33 +0100
Halil Pasic <pasic@...ux.ibm.com> wrote:

> On Fri, 16 Nov 2018 11:47:48 +0100
> Petr Tesarik <ptesarik@...e.com> wrote:
> 
> > The driver uses test_facility(), but does not include the
> > corresponding include file explicitly. The driver currently builds
> > only thanks to the following include chain:
> > 
> >   vfio_ap_drv.c
> >     <linux/module.h>
> >       <linux/elf.h>
> >         <asm/elf.h>
> > 	  <linux/compat.h>
> > 	    <asm/uaccess.h>
> > 	      <asm/facility.h>
> > 
> > Files should not rely on such fragile implicit includes.
> > 
> > Signed-off-by: Petr Tesarik <ptesarik@...e.com>
> > ---
> >  drivers/s390/crypto/vfio_ap_drv.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/s390/crypto/vfio_ap_drv.c
> > b/drivers/s390/crypto/vfio_ap_drv.c index 7667b38728f0..31c6c847eaca
> > 100644 --- a/drivers/s390/crypto/vfio_ap_drv.c
> > +++ b/drivers/s390/crypto/vfio_ap_drv.c
> > @@ -11,6 +11,7 @@
> >  #include <linux/mod_devicetable.h>
> >  #include <linux/slab.h>
> >  #include <linux/string.h>
> > +#include <asm/facility.h>
> >  #include "vfio_ap_private.h"
> >  
> >  #define VFIO_AP_ROOT_NAME "vfio_ap"  
> 
> Applied. Is going to go via Martins S390 tree.

Thank you for the quick turnaround.

Petr Tesarik
SUSE HW Enablement Team