linux-kernel - Re: [PATCH] perf build: fix -lbfd feature check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181116133420.GA29750@krava>
Date:   Fri, 16 Nov 2018 14:34:20 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        acme@...nel.org, alexander.shishkin@...ux.intel.com,
        namhyung@...nel.org, mathieu.poirier@...aro.org, mingo@...nel.org
Subject: Re: [PATCH] perf build: fix -lbfd feature check

On Thu, Nov 15, 2018 at 04:32:01PM -0800, Stanislav Fomichev wrote:
> Current libbfd feature test unconditionally links against -liberty and -lz.
> While it's required on some systems (e.g. opensuse), it's completely
> unnecessary on the others, where only -lbdf is sufficient (debian).
> This patch streamlines (and renames) the following feature checks:
> 
> feature-libbfd           - only link against -lbfd (debian),
>                            see commit 2cf9040714f3 ("perf tools: Fix bfd
> 			   dependency libraries detection")
> feature-libbfd-liberty   - link against -lbfd and -liberty
> feature-libbfd-liberty-z - link against -lbfd, -liberty and -lz (opensuse),
>                            see commit 280e7c48c3b8 ("perf tools: fix BFD
> 			   detection on opensuse")
> 
> (feature-liberty{,-z} were renamed to feature-libbfd-liberty{,z}
> for clarity)
> 
> The main motivation is to fix this feature test for bpftool which is
> currently broken on debian (libbfd feature shows OFF, but we still
> unconditionally link against -lbfd and it works).
> 
> Tested on debian with only -lbfd installed (without -liberty); I'd
> appreciate if somebody on the other systems can test this new detection
> method.
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

looks good, Fedora goes with standalone libbfd

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka