linux-kernel - Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1811161034500.1487-100000@iolanthe.rowland.org>
Date:   Fri, 16 Nov 2018 10:38:18 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
cc:     Ben Dooks <ben-linux@...ff.org>, <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...ts.codethink.co.uk>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count

On Fri, 16 Nov 2018, Ben Dooks wrote:

> On 14/11/18 18:47, Alan Stern wrote:
> > On Wed, 14 Nov 2018, Ben Dooks wrote:
> > 
> >> From: Ben Dooks <ben.dooks@...ethink.co.uk>
> >>
> >> At least some systems benefit with less scheduling if the NAK count
> >> value is set higher than the default 4. For instance a Tegra3 with
> >> an SMSC9512 showed less interrupt load when this was changed to 14.
> > 
> > Interesting.  Why do you think this is?  In theory, increasing the NAK
> > count RL value should cause a higher memory bus load and perhaps a
> > slight rise in the interrupt load (transfers will complete a little
> > more quickly because the controller tries harder to poll the endpoints
> > and see if they are ready).
> 
> I thought the NAK counter was decremented until the transfer is given
> up on.

That's right.  So if the RL value is higher, there will be more polling
attempts in quick succession before the NAK counter drops to 0 and the
controller gives up.  More polling attempts in quick succession means 
heavier memory bus usage.

> I'm going to have to go back and get some actual figures from
> a running system as this was originally done over a year ago with the
> SMSC9512 (IIRC) network driver.
> 
> >> To allow the changing of this value, add a sysfs node to each of
> >> the controllers to allow run-time changing.
> >>
> >> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> > 
> > The patch looks okay to me.
> 
> I'll look at getting some tracing from the SMSC driver to see what
> is going on.

Okay.  Should we consider the patch to be held in suspense until then?

Alan Stern