linux-kernel - Re: [PATCH] mtd: spi-nor: fix selection of uniform erase type in flexible conf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c2c7a76-c7da-5c6e-0bb3-8963132f79d4@microchip.com>
Date:   Fri, 16 Nov 2018 17:36:53 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <marek.vasut@...il.com>, <dwmw2@...radead.org>,
        <computersforpeace@...il.com>, <boris.brezillon@...tlin.com>,
        <richard@....at>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: fix selection of uniform erase type in
 flexible conf



On 11/16/2018 01:17 PM, Tudor Ambarus - M18064 wrote:

[cut]
> @@ -2729,9 +2751,8 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,
>  	 * uniform_erase_type bitmask. The bitmask will be used later on when
>  	 * selecting the uniform erase.
>  	 */
> -	spi_nor_regions_sort_erase_types(map);
> -	map->uniform_erase_type = map->uniform_region.offset &
> -				  SNOR_ERASE_TYPE_MASK;
> +	map->uniform_erase_type = spi_nor_sort_erase_mask(map,
> +						map->uniform_erase_type);

Even if this particular change does not affect how erase works in uniform case,
it is not quite good because map->uniform_erase_type will not reflect what is in
map->uniform_region.offset & SNOR_ERASE_TYPE_MASK.

This change will be removed in v2.

Cheers,
ta