linux-kernel - Re: [PATCH] udmabuf: set read/write flag when exporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfnVBmhpMDi8EVUNZxWTU38ZWoO61eyG1-=bRqoe3hoQ08E0A@mail.gmail.com>
Date:   Thu, 15 Nov 2018 17:46:30 -0800
From:   Gurchetan Singh <gurchetansingh@...omium.org>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     ML dri-devel <dri-devel@...ts.freedesktop.org>,
        sumit.semwal@...aro.org, linux-media@...r.kernel.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udmabuf: set read/write flag when exporting

Reviewed-by: Gurchetan Singh <gurchetansingh@...omium.org>
Tested-by: Gurchetan Singh <gurchetansingh@...omium.org>
On Wed, Nov 14, 2018 at 4:20 AM Gerd Hoffmann <kraxel@...hat.com> wrote:
>
> Otherwise, mmap fails when done with PROT_WRITE.
>
> Suggested-by: Gurchetan Singh <gurchetansingh@...omium.org>
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
> ---
>  drivers/dma-buf/udmabuf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index e70328ab7e..d9ff246093 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -189,6 +189,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
>         exp_info.ops  = &udmabuf_ops;
>         exp_info.size = ubuf->pagecount << PAGE_SHIFT;
>         exp_info.priv = ubuf;
> +       exp_info.flags = O_RDWR;
>
>         buf = dma_buf_export(&exp_info);
>         if (IS_ERR(buf)) {
> --
> 2.9.3
>