linux-kernel - Re: [PATCH v2 2/2] x86: set a dependency on macros.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C359F0E6-2920-428F-B93E-7C76E564C1BA@vmware.com>
Date:   Fri, 16 Nov 2018 20:18:58 +0000
From:   Nadav Amit <namit@...are.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     Ingo Molnar <mingo@...hat.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S

From: Masahiro Yamada
Sent: November 16, 2018 at 7:37:46 AM GMT
> To: Nadav Amit <namit@...are.com>
> Cc: Ingo Molnar <mingo@...hat.com>, Michal Marek <michal.lkml@...kovi.net>, Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, H. Peter Anvin <hpa@...or.com>, X86 ML <x86@...nel.org>, Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S
> 
> 
> On Thu, Nov 15, 2018 at 1:01 PM Nadav Amit <namit@...are.com> wrote:
>> Changes in macros.S should trigger the recompilation of all C files, as
>> the macros might need to affect their compilation.
>> 
>> Acked-by: Ingo Molnar <mingo@...nel.org>
>> Signed-off-by: Nadav Amit <namit@...are.com>
>> ---
> 
> When we talked about this last time,
> we agreed to not do this
> because a single line change in asm headers
> would cause global rebuilding.
> 
> Did you change your mind?

I was wrong (and you were right? I don’t quite remember). Anyhow, another
patch I work on made me realize how wrong I was.

If required, we can extract the macros from some of the header files into
separate header files to prevent unnecessary rebuilds.

Thanks,
Nadav